Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split CI GitHub Actions #861

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Split CI GitHub Actions #861

merged 1 commit into from
Nov 14, 2023

Conversation

lslezak
Copy link
Contributor

@lslezak lslezak commented Nov 13, 2023

Problem

  • We always run all CI GitHub Actions, even for components which are not changed
  • E.g. when you change some Ruby code we run also the unit tests for the Rust code which is actually not needed
  • That wastes resources and the CI takes longer time than needed
  • You might get a false alarm if tests in the other part fail e.g. because of some network problem

Solution

Notes

  • The result is that when you edit a file which is not actively used by any part (like updating README.md file) then no unit test will run and there will be no green check mark ✅ in the pull request. Just be prepared for that... 😉
  • The paths matching is set for any change in the directory besides some listed exceptions. If there are some more files which do not influence the tests they can be added later. But it is safer to run one more unnecessary build than to skip one important build.

Testing

@coveralls
Copy link

coveralls commented Nov 13, 2023

Coverage Status

coverage: 72.616% (-2.5%) from 75.104%
when pulling c54f776 on lslezak:master
into 51a9970 on openSUSE:master.

@lslezak lslezak merged commit c71d0d9 into agama-project:master Nov 14, 2023
3 checks passed
@imobachgs imobachgs mentioned this pull request Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants